Re: [PATCH v3 3/6] ASoC: WM8903: Pass pdata to wm8903_init_gpio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 01, 2011 at 01:49:21PM -0700, Stephen Warren wrote:

> -	if (pdata && pdata->gpio_base)
> -		wm8903->gpio_chip.base = pdata->gpio_base;
> -	else
> -		wm8903->gpio_chip.base = -1;
> +	wm8903->gpio_chip.base = pdata->gpio_base;

This will break existing users in counjuntion with the previous patch.
Previously if the user provided platform data but left gpio_base as zero
we'd use -1 and let gpiolib pick for us.  Now instead the driver will
take that zero and pass it on to gpiolib, probably failing as the SoC
will have taken the low numbered GPIOs.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux