On 11/17/2011 09:07 AM, Peter De Schrijver wrote:
> Convert tegra20 IRQ intialization to the GIC devicetree binding. Modify the
> interrupt definitions in the dts files according to
> Documentation/devicetree/bindings/arm/gic.txt
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
One minor comment below, but otherwise:
Acked-by: Rob Herring <rob.herring@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/tegra-paz00.dts | 2 +-
> arch/arm/boot/dts/tegra20.dtsi | 52 ++++++++++++++++++------------------
> arch/arm/mach-tegra/irq.c | 18 +++++++++++-
> 3 files changed, 43 insertions(+), 29 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-paz00.dts
> index 15a949f..7ff8f6f 100644
> --- a/arch/arm/boot/dts/tegra-paz00.dts
> +++ b/arch/arm/boot/dts/tegra-paz00.dts
> @@ -32,7 +32,7 @@
> #size-cells = <0>;
> compatible = "nvidia,nvec";
> reg = <0x7000C500 0x100>;
> - interrupts = <124>;
> + interrupts = <0 92 0x04>;
> clock-frequency = <80000>;
> request-gpios = <&gpio 170 0>;
> slave-addr = <138>;
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 795b921..cd01b01 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -5,9 +5,9 @@
> interrupt-parent = <&intc>;
>
> intc: interrupt-controller@50041000 {
> - compatible = "nvidia,tegra20-gic";
> + compatible = "arm,cortex-a9-gic";
> interrupt-controller;
You should add an "interrupt-parent;" here so the gic's parent is null
and not the gic.
Rob
> - #interrupt-cells = <1>;
> + #interrupt-cells = <3>;
> reg = < 0x50041000 0x1000 >,
> < 0x50040100 0x0100 >;
> };
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
