>> TEGRA has a hardware spinlock block which is used >> to get exclusive access to the hardware blocks either >> from the CPU or the COP. The TEGRA hardware spinlock >> block has the capability to interrupt the requester >> on success. For this the core need not disable >> preemption or interrupts before calling into the >> actual driver. Add lock_timeout to the ops structure >> to facilitate this working and to maintain backward >> compatibility. > You're using "TEGRA" in the patch description, but below it is spelled > "Tegra". Should this be made consistent? > > Also, this patch should probably be paired with a patch that actually uses > the new field. That would make it easier to understand the reason for this > change. > Actually, the basic idea is to keep preemption and interrupts enabled for SoCs similar to Tegra. Since the previous architecture is designed for the OMAP line of preocessors, fitting the Tegra hwspinlock driver was not possible. Instead of going about changing the framework and then the OMAP drivers, I thought of adding another callback to the ops structure which can sleep and does not need interrupts to be disabled. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
