Marc Dietrich wrote at Wednesday, October 26, 2011 1:59 PM: > This adds a dts file for paz00. As a side effect, this also enables > the embedded controller which controls the keyboard, touchpad, power, > leds, and some other functions. ... > +++ b/arch/arm/boot/dts/tegra-paz00.dts > @@ -0,0 +1,70 @@ > +/dts-v1/; > + > +/memreserve/ 0x1c000000 0x04000000; > +/include/ "tegra20.dtsi" > + > +/ { > + model = "Toshiba AC100 / Dynabook AZ"; > + compatible = "compal,paz00", "nvidia,tegra20"; > + > + chosen { > + bootargs = "mem=448@0 console=ttyS0,115200n8 root=/dev/mmcblk1p1"; You shouldn't need the mem= parameter here; it wasn't in your first patch set. > + }; > + > + memory@0 { > + reg = <0x00000000 0x20000000>; > + }; > + > + i2c@7000c000 { > + clock-frequency = <400000>; > + }; > + > + i2c@7000c400 { > + clock-frequency = <400000>; > + }; > + > + i2c@7000c500 { > + status = "disable"; > + }; > + > + nvec@7000c500 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "nvidia,nvec"; I'm not convinced that's the correct compatible value, but I should discuss this more in the nvec patch... > + reg = <0x7000C500 0x100>; > + interrupts = <124>; > + clock-frequency = <80000>; > + request-gpios = <&gpio 170 0>; > + slave-addr = <138>; > + }; > +++ b/arch/arm/mach-tegra/Makefile > @@ -31,6 +31,7 @@ obj-${CONFIG_MACH_SEABOARD} += board-seaboard-pinmux.o > > obj-${CONFIG_MACH_TEGRA_DT} += board-dt.o > obj-${CONFIG_MACH_TEGRA_DT} += board-harmony-pinmux.o > +obj-$(CONFIG_MACH_TEGRA_DT) += board-paz00-pinmux.o > obj-${CONFIG_MACH_TEGRA_DT} += board-seaboard-pinmux.o What branch is your patch based on? Those lines use braces not brackets in the latest code (incorrect yes, but that's what's there; Olof said he'll fix it for the next merge window). Do you have some local patches in your branch before this patchset? Note: Feel free to add your lines using the correct syntax; I'm just wondering about the existing context in your patch. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html