On Tue, Oct 25, 2011 at 7:52 AM, Thierry Reding
<thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
> * Stephen Warren wrote:
>> Marc Dietrich wrote at Monday, October 24, 2011 3:28 PM:
>> > On Monday 24 October 2011 12:01:07 Stephen Warren wrote:
>> > > * Add device-tree file for TrimSlice
>> > > * Add that to the list of .dts files to build
>> > > * Update board-dt.c to recognize TrimSlice board name
>> > >
>> > > Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
>> > > ---
>> > > arch/arm/boot/dts/tegra-trimslice.dts | 38
>> > > +++++++++++++++++++++++++++++++++ arch/arm/mach-tegra/Makefile.boot |
>> > > 1 +
>> > > arch/arm/mach-tegra/board-dt.c | 3 ++
>> > > 3 files changed, 42 insertions(+), 0 deletions(-)
>> > > create mode 100644 arch/arm/boot/dts/tegra-trimslice.dts
>> >
>> > doesn't this also require to add something like
>> >
>> > obj-${CONFIG_MACH_TEGRA_DT} += board-trimslice-pinmux.o
>> >
>> > to the Makefile?
>>
>> Yes, definitely. I've fixed this up locally; I hope to repost soon.
>
> Can it please be obj-$(CONFIG_MACH_TEGRA_DT) instead? I think both Russell
> and Olof agreed[0] to use parens instead of braces, even though the current
> practice is to copy what previous boards did.
Ah yeah, I forgot to clean that up for 3.2, I'll post a patch shortly.
Braces are nonstandard, and will continue to proliferate if left in
there.
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
