On Sat, Oct 22, 2011 at 1:16 PM, Marc Dietrich <marvin24@xxxxxx> wrote:
> This adds support for the embedded controller known as NVEC. The driver
> lives currently in the staging tree and we aim to promote it one level
> higher in the near future.
>
> The NVEC driver uses the I2C resources of the master controller for now
> until slave support is added to the i2c-tegra driver.
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index 602f8dd..3f46b37 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -44,6 +44,8 @@
> #include "devices.h"
> #include "gpio-names.h"
>
> +#include "../../../drivers/staging/nvec/nvec.h"
Ick, no! Move the header file containing platform data to
include/linux/platform_data instead (or break it off in a separate
header file).
> static struct platform_device *paz00_devices[] __initdata = {
> &debug_uart,
> &tegra_sdhci_device4,
> @@ -127,6 +134,10 @@ static void paz00_i2c_init(void)
> platform_device_register(&tegra_i2c_device1);
> platform_device_register(&tegra_i2c_device2);
> platform_device_register(&tegra_i2c_device4);
> +
> + tegra_i2c_device3.name = "nvec";
> + tegra_i2c_device3.dev.platform_data = &nvec_pdata;
> + platform_device_register(&tegra_i2c_device3);
Please define a separate platform_device instead of hijacking the
current one, please.
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
