Hi, On Wed, Oct 19, 2011 at 4:29 AM, Leon Romanovsky <leon@xxxxxxx> wrote: > On Tue, Oct 18, 2011 at 18:10, Stephen Warren <swarren@xxxxxxxxxx> wrote: >> Marc Dietrich wrote at Tuesday, October 18, 2011 9:50 AM: >>> On Monday 17 October 2011 08:29:01 Stephen Warren wrote: >>> > Marc Dietrich wrote at Saturday, October 15, 2011 10:34 AM: >>> > > Am Samstag 15 Oktober 2011, 17:18:33 schrieb Leon Romanovsky: >>> > > > This fix updates the CDEV1 pinmux for the paz00 board to be as in the >>> > > > Harmony board. Paz00 board is originally based on Harmony design. >>> > > >>> > > the fact that this patch makes sound work on paz00 does not necessary mean >>> > > that this is the "right thing" to do. >>> > None of the other boards do that, and the drivers don't support it. I >>> > believe the clock would need to be started as soon as the audio driver >>> > module were loaded, and kept running as long as it was loaded, so there's >>> > not much chance of optimizing power here at the moment. >>> >>> Which driver? >> >> The whole ASoC driver stack. It may depend on the codec, but I assume that >> CDEV1 clock output should be running the whole time the ASoC codec driver >> is active. Alsa-devel would be the best place to ask about that kind of >> thing. > > Let's summarize, we agree that it is a correct way to handle CDEV1, > and it is a correct patch. > I believe it is a good time to merge the patch before we start to > merge the codec itself. It'll be staged for 3.3 when I start those branches, which should be soon. We're close to the merge window, it's not a regression fix and you need other changes on top of it anyway to get anything useful out of it -- so it can wait. Thank you for posting it early though, and I'll make sure it makes it into linux-next quickly so you can use that as a base for your codec work. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
