On Tue, Oct 11, 2011 at 4:16 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote: > v3: Make regs variable static. Remove empty init of tegra_gpio_banks. > > v2: Retrieve IRQ and memory addresses from resources instead of hard- > coding them. Add back initialization of tegra_gpio_chip.of_node. > > Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx> One comment below however. > @@ -333,28 +335,55 @@ static struct irq_chip tegra_gpio_irq_chip = { > */ > static struct lock_class_key gpio_lock_class; > > -static int __init tegra_gpio_init(void) > +static int __init tegra_gpio_probe(struct platform_device *pdev) __devinit because this is put in the .probe hook of the driver. g. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html