Hi Olof, Am Montag, 10. Oktober 2011, 10:45:48 schrieb Olof Johansson: > I can't reproduce this problem. CONFIG_SPI doesn't seem to be on for > tegra_defconfig (I'll revisit the defconfig and turn on missing > options for 3.2), but even after I enable it (plus CONFIG_SPI_TEGRA), > I don't see any errors here. I tried static build as well as module. > Can you provide more detail to what you're seeing? ah, sorry, it is needed for linux-next (which also happens to have a 3.1-rc9 version). You can easily check if include/linux/device.h has module.h included or not (if not, tegra-spi fails to compile). I updated the subject. > Also, for future patches: > > * Please add your free-form comment below the "---" in the commit > message. That way git apply-mbox will just automatically do the right > thing and leave it out from the patch ok, this wasn't obvious to me. I can send a new patch if needed. > * If you include the compiler error output it's easier for others to > find the error on the lists and avoid duplicate patch submissions. here it goes: CC drivers/spi/spi-tegra.o drivers/spi/spi-tegra.c:597: error: expected declaration specifiers or ‘...’ before string constant drivers/spi/spi-tegra.c:597: warning: data definition has no type or storage class drivers/spi/spi-tegra.c:597: warning: type defaults to ‘int’ in declaration of ‘MODULE_ALIAS’ drivers/spi/spi-tegra.c:597: warning: function declaration isn’t a prototype drivers/spi/spi-tegra.c:604: warning: data definition has no type or storage class drivers/spi/spi-tegra.c:604: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’ drivers/spi/spi-tegra.c:604: warning: parameter names (without types) in function declaration drivers/spi/spi-tegra.c:612: error: ‘THIS_MODULE’ undeclared here (not in a function) drivers/spi/spi-tegra.c:630: error: expected declaration specifiers or ‘...’ before string constant drivers/spi/spi-tegra.c:630: warning: data definition has no type or storage class drivers/spi/spi-tegra.c:630: warning: type defaults to ‘int’ in declaration of ‘MODULE_LICENSE’ drivers/spi/spi-tegra.c:630: warning: function declaration isn’t a prototype make[2]: [drivers/spi/spi-tegra.o] Error 1 Marc > On Mon, Oct 10, 2011 at 2:17 AM, Marc Dietrich <marvin24@xxxxxx> wrote: > > Hi Olof, > > > > sorry for being so late, but here is another last minute patch. > > > > Marc > > > > ----- > > > > spi/tegra: fix compilation error in spi-tegra.c > > > > This adds the missing #include <linux/module.h> to spi-tegra.c > > > > Signed-off-by: Marc Dietrich <marvin24@xxxxxx> > > > > diff --git a/drivers/spi/spi-tegra.c b/drivers/spi/spi-tegra.c > > index a5a6302..e8cd58f 100644 > > --- a/drivers/spi/spi-tegra.c > > +++ b/drivers/spi/spi-tegra.c > > @@ -18,6 +18,7 @@ > > */ > > > > #include <linux/kernel.h> > > +#include <linux/module.h> > > #include <linux/init.h> > > #include <linux/err.h> > > #include <linux/platform_device.h> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
