Re: [PATCH v2 10/14] ARM: tegra: tegra_powergate_is_powered should be static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 10-10-2011 9:28, Olof Johansson wrote:

Not exported and not used externally.

Also, fix return type  and change to instead WARN_ON on bad parameters.

   Change to what? You're changing _to_ WARN_ON() as we can see, not from it...

Signed-off-by: Olof Johansson<olof@xxxxxxxxx>
---
  arch/arm/mach-tegra/include/mach/powergate.h |    1 -
  arch/arm/mach-tegra/powergate.c              |    5 ++---
  2 files changed, 2 insertions(+), 4 deletions(-)

[...]
diff --git a/arch/arm/mach-tegra/powergate.c b/arch/arm/mach-tegra/powergate.c
index 3cee9aa..9483064 100644
--- a/arch/arm/mach-tegra/powergate.c
+++ b/arch/arm/mach-tegra/powergate.c
@@ -89,12 +89,11 @@ int tegra_powergate_power_off(int id)
  	return tegra_powergate_set(id, false);
  }

-bool tegra_powergate_is_powered(int id)
+static bool tegra_powergate_is_powered(int id)
  {
  	u32 status;

-	if (id < 0 || id >= TEGRA_NUM_POWERGATE)
-		return -EINVAL;
+	WARN_ON(id<  0 || id>= TEGRA_NUM_POWERGATE);

  	status = pmc_read(PWRGATE_STATUS)&  (1<<  id);
  	return !!status;

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux