Shawn Guo wrote at Saturday, August 13, 2011 7:09 AM: > On Fri, Aug 12, 2011 at 04:54:45PM -0600, Stephen Warren wrote: > > This patch modifies Tegra's device tree support to remove the dependency > > on harmony_pinmux_init(), thus making it completely board-independent. > > > > Some notes: > > ... > > * tegra_pinmux_probe_dt() enumerates all legal pingroup names, and searches > > for a pinmux controller subnode of that name, then processes each one > > that is found. An alternative that some may prefer would be to enumerate > > each child node of the pinmux controller, and have each node contain an > > explicit pingroup name property instead. Does anyone have any preference > > here? I suppose the latter option would obviate the need to add > > of_find_child_node_by_name(). > > I agree with Jamie that the latter option seems better/simper. OK, I'll flip the iteration around. ... > > arch/arm/boot/dts/tegra-harmony.dts | 479 ++++++++++++++++++++++++++ > > arch/arm/boot/dts/tegra-seaboard.dts | 409 ++++++++++++++++++++++ > > arch/arm/boot/dts/tegra20.dtsi | 5 + > > arch/arm/mach-tegra/Makefile | 1 - > > arch/arm/mach-tegra/board-dt.c | 12 +- > > arch/arm/mach-tegra/board-harmony-pinmux.c | 8 + > > arch/arm/mach-tegra/board-paz00-pinmux.c | 8 + > > arch/arm/mach-tegra/board-seaboard-pinmux.c | 9 +- > > arch/arm/mach-tegra/board-trimslice-pinmux.c | 7 + > > arch/arm/mach-tegra/devices.c | 10 + > > arch/arm/mach-tegra/devices.h | 2 + > > arch/arm/mach-tegra/pinmux.c | 136 ++++++++ > > drivers/gpio/gpio-tegra.c | 56 +++- > > drivers/of/base.c | 18 + > > include/linux/of.h | 2 + > > 15 files changed, 1138 insertions(+), 24 deletions(-) > > > Generally, you need to document the bindings you come with in > Documentation/devicetree/bindings/ Uggh. I must have run format-patch on the wrong commit ID; the last thing I did was to add a couple commits containing the documentation:-( I really shouldn't try to post patch series last thing on Friday... -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
