On Wed, Jul 20, 2011 at 11:40:28AM -0700, Stephen Warren wrote: > Grant Likely wrote at Wednesday, July 20, 2011 12:32 PM: > > The compatible property here definitely represents the hardware > > because it reflects the sound infrastructure on the harmony board. > > I can see that argument for "nvidia,harmony-sound". > > But "nvidia,tegra-wm8903" is pretty generic; I can certainly see there > being Tegra 20 systems that use a WM8903 but are so different from either > Harmony or anything supported by sound/soc/tegra/tegra_wm8903.c that the > existing driver isn't applicable. And hence, there may be a different > ASoC driver for such board(s), and hence choosing such a generic name as > "tegra-wm8903" for Harmony/Seaboard's audio layout seems like it might > cause problems in the future. > > I'm fine with such a generic name for the platform driver, since that name > can fairly easily be modified just by editing the driver and the board file. > But since *.dts files are at least logically separate from the kernel, such > naming future-proofing is a little more important. Sure, the tegra-wm8903 property can be dropped. If we start to see a really well established pattern of the tegra paired with a wm8903, then at that point we can define a compatible property for it and document exactly what it means (document the boundaries and assumptions that the compatible value requires). g. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
