John Bonesio wrote at Tuesday, May 10, 2011 2:14 PM:
> This patch changes how sdhci devices are initialized so that a later patch can
> easily add support for i2c devies.
>
> Signed-off-by: John Bonesio <bones@xxxxxxxxxxxx>
> @@ -134,6 +57,25 @@ static __initdata struct tegra_clk_init_table
> tegra_dt_clk_init_table[] = {
> { NULL, NULL, 0, 0},
> };
>
> +static struct tegra_sdhci_platform_data sdhci_pdata1 = {
> + .cd_gpio = -1,
> + .wp_gpio = -1,
> + .power_gpio = -1,
> +};
> +
> +static struct tegra_sdhci_platform_data sdhci_pdata2 = {
> + .cd_gpio = TEGRA_GPIO_SD2_CD,
> + .wp_gpio = TEGRA_GPIO_SD2_WP,
> + .power_gpio = TEGRA_GPIO_SD2_POWER,
> +};
> +
> +static struct tegra_sdhci_platform_data sdhci_pdata4 = {
> + .cd_gpio = TEGRA_GPIO_SD4_CD,
> + .wp_gpio = TEGRA_GPIO_SD4_WP,
> + .power_gpio = TEGRA_GPIO_SD4_POWER,
> + .is_8bit = 1,
> +};
> +
So I understand why board-dt is itself registering the SDHCI platform
devices itself; so that the pdev initialization path is identical
between fully hard-coded boards and board-dt.c.
However, I'm surprised that we would include the platform data for
those devices within that argument; if we do that, we'll end up needing
different platform data for every board, and devicetree won't have
bought us anything.
In other words, I understood that board-dt would register all the
platform devices within Tegra, but not set up any of the plataform
data, and the device drivers for those devices would be updated to
get their platform data from devicetree if available, then fall back
to old-style platform data. In other words, the way the SDHCI drivers
work today in the devicetree/test branch.
If my understanding is correct, shouldn't the chunk above and the
one below be removed?
> static struct of_device_id tegra_dt_match_table[] __initdata = {
> { .compatible = "simple-bus", },
> {}
> @@ -164,6 +106,10 @@ static void __init tegra_dt_init(void)
>
> harmony_pinmux_init();
>
> + tegra_sdhci_device1.dev.platform_data = &sdhci_pdata1;
> + tegra_sdhci_device2.dev.platform_data = &sdhci_pdata2;
> + tegra_sdhci_device4.dev.platform_data = &sdhci_pdata4;
> +
> platform_add_devices(harmony_devices, ARRAY_SIZE(harmony_devices));
>
> /*
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
