On Mon, Mar 28, 2011 at 10:12 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > The core code handles thees already. thees -> these > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Colin Cross <ccross@xxxxxxxxxxx> > Cc: linux-tegra@xxxxxxxxxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > --- > arch/arm/mach-tegra/gpio.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > Index: linux-2.6-tip/arch/arm/mach-tegra/gpio.c > =================================================================== > --- linux-2.6-tip.orig/arch/arm/mach-tegra/gpio.c > +++ linux-2.6-tip/arch/arm/mach-tegra/gpio.c > @@ -275,13 +275,6 @@ void tegra_gpio_resume(void) > } > > local_irq_restore(flags); > - > - for (i = INT_GPIO_BASE; i < (INT_GPIO_BASE + TEGRA_NR_GPIOS); i++) { > - struct irq_desc *desc = irq_to_desc(i); > - if (!desc || (desc->status & IRQ_WAKEUP)) > - continue; > - enable_irq(i); > - } > } > > void tegra_gpio_suspend(void) > @@ -289,18 +282,6 @@ void tegra_gpio_suspend(void) > unsigned long flags; > int b, p, i; > > - for (i = INT_GPIO_BASE; i < (INT_GPIO_BASE + TEGRA_NR_GPIOS); i++) { > - struct irq_desc *desc = irq_to_desc(i); > - if (!desc) > - continue; > - if (desc->status & IRQ_WAKEUP) { > - int gpio = i - INT_GPIO_BASE; > - pr_debug("gpio %d.%d is wakeup\n", gpio/8, gpio&7); > - continue; > - } > - disable_irq(i); > - } > - > local_irq_save(flags); > for (b = 0; b < ARRAY_SIZE(tegra_gpio_banks); b++) { > struct tegra_gpio_bank *bank = &tegra_gpio_banks[b]; > > > This will cause warnings in both the suspend and resume functions as i is now unused. Other than that: Acked-by: Colin Cross <ccross@xxxxxxxxxxx> Do you want me to take this through the Tegra tree for 2.6.39-rc1? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html