Hi, Cross Sorry, I made some confusion. In my description for this upstream, I said the tps6586x_irq() will try to read register before i2c resume. In here, the tps6586x_irq() is from drivers/mfd/tps6586x.c, not drivers/rtc/rtc-tps6586x.c I had tried to add disable/enable in suspend/resume for this mfd tps6586x driver, it also can fix this issue. So does there mean we should change the /drivers/mfd/tps6586x.c ? Thanks Wei. -----Original Message----- From: ccross@xxxxxxxxxx [mailto:ccross@xxxxxxxxxx] On Behalf Of Colin Cross Sent: Monday, March 28, 2011 3:05 PM To: Wei Ni Cc: khali@xxxxxxxxxxxx; ben-linux@xxxxxxxxx; snanda@xxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Varun Wadekar Subject: Re: [PATCH] i2c: busses: i2c-tegra: Using suspend_noirq()/resume_noirq() for suspend/resume On Sun, Mar 27, 2011 at 11:59 PM, Wei Ni <wni@xxxxxxxxxx> wrote: > Hi, Colin > The irq in rtc-tps6586x is the alarm interrupt, I had tried to disable/enable it > as you said, but the system couldn't be resumed by wakealarm. > I think it's better to change the i2c-tegra.c Disabling an interrupt does not prevent waking from suspend on that interrupt if enable_irq_wake has also been called. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
