On Sun, Feb 20, 2011 at 05:14:21PM -0800, Colin Cross wrote: > Adds I2C bus driver for nVidia Tegra SoCs. Tegra includes 4 I2C > controllers, one of which is inside the Dynamic Voltage Controller > and has a slightly different register map. > > Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx> Would have been helpful to start a new thread, missed this the first time around. > + i2c_dev = kzalloc(sizeof(struct tegra_i2c_dev), GFP_KERNEL); > + if (!i2c_dev) { no error print here. > + ret = -ENOMEM; > + goto err_i2c_clk_put; > + } > + if (pdev->id == 3) > + i2c_dev->is_dvc = 1; > + init_completion(&i2c_dev->msg_complete); you might want to think about having a seperate platform bus name for this case, and switching the is_dvc field on that. It'll make life much easier if someone decides that what the next tegra i2c needs is 5 i2c controllers. I'll consider putting this (as is) into the -next tree, but would like to see the issues with readsl/writesl sorted out and any other review comments sorted. -- Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html