On Mon, Feb 21, 2011 at 2:58 PM, Erik Gilling <konkers@xxxxxxxxxxx> wrote: > On Mon, Feb 21, 2011 at 12:44 PM, Olof Johansson <olof@xxxxxxxxx> wrote: >> Hi, >> >> On Mon, Feb 21, 2011 at 11:40 AM, Erik Gilling <konkers@xxxxxxxxxxx> wrote: >> >>>> This should remove the need for calling these from specific drivers and >>>> thus reduce tegra-specific code from them. >>> >>> It was never my intention that drives call gpio_enable/disable, just board >>> files. >> >> True, but it seems even then that it ends up in various parts of the >> per-board files. Having it in one central location (for the base >> config) seems like a good idea. > > sounds good to me. > >>> Gpio subsystem init and configurations should be left separate. >> >> I.e. not part of the pinmux file? Sure, can do. > > I meant that tegra_gpio_init should still be a postcore_initcall. > That way GPIOs work even if you don't use the tegra_gpio_config > helper. Ok, brought that back. > Also, I'd take the __init off tegra_gpio_config. The > function could be useful in some suspend/resume chains where the board > designer hates you. While I agree that it'd be useful, I'd prefer dropping it when the first in-tree user comes along for it. Otherwise, chances is some janitor coming across it and adding it back for extra churn. :) -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
