On Mon, Feb 21, 2011 at 7:07 PM, Colin Cross <ccross@xxxxxxxxxxx> wrote:
> On Mon, Feb 21, 2011 at 11:06 AM, Olof Johansson <olof@xxxxxxxxx> wrote:
>> +config MACH_SEABOARD
>> + bool "Seaboard board family"
>> + help
>> + Support for nVidia Seaboard development platform
>> +
>> +config MACH_KAEN
>> + bool "Kaen board"
>> + depends on MACH_SEABOARD
>> + help
>> + Support for the Kaen version of Seaboard
>> +
>> +config MACH_WARIO
>> + bool "Wario board"
>> + depends on MACH_SEABOARD
>> + help
>> + Support for the Wario version of Seaboard
>> +
> It's easier to prevent merge conflicts if these stay in alphabetical
> order. Even though these 3 are closely related, the next person to
> add a board is going to assume they are not in alphabetical order and
> put theirs at the bottom. I would also suggest "selects
> MACH_SEABOARD" instead of "depends on MACH_SEABOARD", which will help
> when they are out of order.
Works for me. Creates less of an appearance of hierarchy between
different board types too.
>> +++ b/arch/arm/mach-tegra/board-seaboard-pinmux.c
>> @@ -0,0 +1,179 @@
>> +/*
>> + * Copyright (C) 2010 NVIDIA Corporation
> This seems unique enough not be copyright nVidia.
Having copyrights on every single file is silly to start with, but I
carried this over since they had it on the patch that introduced
seaboard in the chromium os repository.
I'll be rewriting the file for next post due to the import from
/sys/kernel/debug as Erik suggested though, so the copyright will
switch for that reason.
>> diff --git a/arch/arm/mach-tegra/board-seaboard.c b/arch/arm/mach-tegra/board-seaboard.c
>> new file mode 100644
>> index 0000000..deeddfe
>> --- /dev/null
>> +++ b/arch/arm/mach-tegra/board-seaboard.c
> <snip>
>> +#include <mach/io.h>
> #include <linux/io.h> instead
>
> <snip>
Thanks.
>> +static void __init __tegra_seaboard_init(void)
>> +{
>> + seaboard_pinmux_init();
>> +
>> + tegra_common_init();
> My recent clock patch series includes a change to replace
> tegra_common_init with tegra_early_init. If my patch goes in before
> this one, you'll need to update this one.
Will do.
[..]
> These should be in the order they are called during init: map_io,
> init_irq, timer, init_machine.
Sure.
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
