Hi, Just a couple of minor nits. I wouldn't worry about respinning just for these comments, but if you end up doing it for other feedback, see below. -Olof On Sun, Feb 20, 2011 at 5:14 PM, Colin Cross <ccross@xxxxxxxxxxx> wrote: > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > new file mode 100644 > index 0000000..3921f66 > --- /dev/null > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -0,0 +1,700 @@ > +/* > + * drivers/i2c/busses/i2c-tegra.c > + * > + * Copyright (C) 2010 Google, Inc. 2011? [..] > +/* > + * i2c_writel and i2c_readl will offset the register if necessary to talk > + * to the I2C block inside the DVC block > + */ > +static unsigned long tegra_i2c_reg_addr(struct tegra_i2c_dev *i2c_dev, > + unsigned long reg) > +{ > + if (i2c_dev->is_dvc) > + reg += (reg >= I2C_TX_FIFO) ? 0x10 : 0x40; > + return reg; > +} > + > +static void i2c_writel(struct tegra_i2c_dev *i2c_dev, u32 val, > + unsigned long reg) > +{ > + writel(val, i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg)); > +} > + > +static u32 i2c_readl(struct tegra_i2c_dev *i2c_dev, unsigned long reg) > +{ > + return readl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg)); > +} > + > +static void i2c_writesl(struct tegra_i2c_dev *i2c_dev, void *data, > + unsigned long reg, int len) > +{ > + writesl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg), data, len); > +} > + > +static void i2c_readsl(struct tegra_i2c_dev *i2c_dev, void *data, > + unsigned long reg, int len) > +{ > + readsl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg), data, len); > +} All of the above pass in i2c_dev to tegra_i2c_reg_addr, might as well do the base addition in there. > diff --git a/include/linux/i2c-tegra.h b/include/linux/i2c-tegra.h > new file mode 100644 > index 0000000..9c85da4 > --- /dev/null > +++ b/include/linux/i2c-tegra.h > @@ -0,0 +1,25 @@ > +/* > + * drivers/i2c/busses/i2c-tegra.c > + * > + * Copyright (C) 2010 Google, Inc. 2011? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html