Hi, On Sun, Feb 20, 2011 at 4:38 AM, Mike Rapoport <mike@xxxxxxxxxxxxxx> wrote: > On 02/20/11 07:44, Olof Johansson wrote: >> PCIe init is really quite simple. The per-board specifications can be >> moved into the base board file instead, and pass in the pinmux groups >> to enable/disable when setting up PCIe. > > This is correct only when you have a bootloader that enables all the supplies > required for PCI to operate. On Harmony you need to enable LDO0 on the TPS > before starting the PCI, otherwise the board will hang... Same will probably be true for more or less every board that uses PCI-e. I guess we'll see as we start to add more boards. The main reason I wanted to move most of the init into pcie.c was to remove what was likely to be duplicated code from new board files. I have a couple of more boards that will be introduced in the not-too-distant future and I wanted to avoid having to do a whole lot of copy-and-edit between them. It's likely to take a while of iterative cleanups and restructuring before we know what scales well though. > I have some implementation of it at [1], but it's not yet upstream ready. Cool, I'll keep an eye on your progress since we now have some boards with PCI-e as well, and our bootloader doesn't enable the PCI-e supplies. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
