After fixing the programming in the patch you've referenced, I've not seen any issues with HDMI audio in either field tests for certification. Those register settings came from the nvidia reference code. -Erik (p.s. I don't know which tree e47469d3fd is from... but it's not in any tree I have in my remotes.) On Tue, Feb 15, 2011 at 12:37 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote: > Erik, > > Can you say how much testing drivers/video/tegra/dc/hdmi.c has had re: > audio-over-HDMI and in what context? I assume some, due to commits such as > e47469d3fd "video: tegra: fix HDMI audio programming". > > I ask because of the following code: > > tegra_hdmi_writel(hdmi, SPARE_HW_CTS | SPARE_FORCE_SW_CTS | > SPARE_CTS_RESET_VAL(1), > HDMI_NV_PDISP_HDMI_SPARE); > > I had to remove SPARE_FORCE_SW_CTS from this register write to get > audio-over-HDMI working correctly. > > As I read the specs, HW_CTS tells the HW to calculate the CTS value itself. > Adding SW_CTS into the mix overrides this request, and requires SW to both > program the selected CTS value into a register *and* program register > HDMI_NV_PDISP_HDMI_ACR_CTRL to tell the HW how to determine the current audio > sample rate, and the latter is not currently done. > > Can you comment any further? > > Thanks. > > -- > nvpublic > > > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html