Yeah, including the relative path was a bit of a hack since the nvhost drivers needs some serious work before it's upstreamable. A "right" way to do this is to have the syncpt functions take an nvhost_device pointer (or create helper functions that do that,) then expose those functions in mach/nvhost.h. This obviates the need for a global nvhost_sycpt pointer. -Erik On Mon, Feb 14, 2011 at 4:08 PM, Andrew Chew <AChew@xxxxxxxxxx> wrote: >> If you want to use syncpts you should be an nvhost_driver link the dc. > > Looking at drivers/video/tegra/dc, I notice that it gets access to the syncpt functions by using a relative path (../host/dev.h) to include dev.h, which in turn includes nvhost_syncpt.h (in drivers/video/tegra/host). Is this proper form? > > This syncpt access is for a Tegra V4L2 driver, which will live in drivers/media/video. I was trying to avoid using relative paths for #includes. I assumed that the header files in drivers/video/tegra/host were not meant to be publicly available to other drivers, which is why I looked for some precedent in how nvhost functions were made available to other kernel drivers, hence I modeled this after nvmap. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
