On Tue, Feb 8, 2011 at 11:05 PM, <rmorell@xxxxxxxxxx> wrote: > On Tue, Feb 08, 2011 at 09:22:04PM -0800, Benoit Goby wrote: > >> +static void ulpi_phy_power_on(struct tegra_usb_phy *phy) >> +{ >> + unsigned long val; >> + void __iomem *base = phy->regs; >> + struct tegra_ulpi_config *config = phy->config; >> + >> + gpio_direction_output(config->reset_gpio, 0); >> + msleep(5); >> + gpio_direction_output(config->reset_gpio, 1); >> + >> + clk_enable(phy->clk); >> + msleep(1); > > This msleep seems excessive. Does it take that long for the clock to > settle? > I tried to use smaller delays but got enumeration issues with delays <1ms, so I'm keeping the msleep. Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html