On Thu, Jan 20, 2011 at 09:23:45AM -0800, Stephen Warren wrote: > Although mainly, I just made it consistent with wm8962.h, which I assume > picked that value for the same reason. 8962 has a very different register map as it has compatiblity with some very old devices. > That said, the original value was OK for the GPIO registers, so I can revert > that if you want. It did stick out as a bit random. > > These should also set GPn_FN - to zero for GPIO output, 3 for GPIO > > input. Otherwise changing between input and output mode at runtime > > won't do the right thing. As a side effect of that you probably > > wouldn't need to specify the GPIO configuration in platform data. > Ooops. I didn't notice that. How does this interact with bit 7; GPn_DIR? I > assume both need to be set appropriately since they're both defined bits. Yes, one controls the function and the other controls the pad mode. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
