On Tue, 2011-01-18 at 16:37 -0700, Stephen Warren wrote: > From: Stephen Warren <swarren@xxxxxxxxxx> > > Harmony has headers on the board for an internal speaker and internal mic. > I've started looking at enabling these, along with full jack detection etc. > This first set of patches is an RFC (Request For Comments) on whether it's > the correct direction, particularly with respect to: > > a) Is this the right way to expose GPIO APIs from a codec? The tlv320aic3 > seems to do it this way, but wm8962.c uses the generic GPIO API. I shied > away from the latter, since I wasn't sure how to name the WM8903's GPIOs > in the gpio_* calls. I suppose it'd need a bunch of GPIO driver platform > data to hook it all together and name GPIOs from a mach-tegra/include > header file, but if this is the way to go, I need to read up on that more. > > b) Is the WM8903 platform_data handling full fleshed out; simply by having > platform_data, WM8903_WSEQ_ENA is set, whereas without any pdata, it > isn't. Should this be conditional, or should I always have specified some > platform data for Tegra, and I'm just getting lucky that it works without > any? > > Thanks for any coments. > 2 & 3 look fine and Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx> -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
