Mark Brown wrote: > On Fri, Dec 17, 2010 at 02:41:21PM -0700, Stephen Warren wrote: > > > --- a/arch/arm/mach-tegra/Kconfig > > +++ b/arch/arm/mach-tegra/Kconfig > > > +config TEGRA_I2S_AUDIO > > + bool "Enable Tegra I2S Audio support" > > + default n > > + help > > + Say Y if you want to add support for i2s audio on tegra. > > This should just be silently selected by the ASoC drivers (so no help > text) if it's really worth controlling in arch/arm. Otherwise you just > have two options both of which need to be selected to enable the audio > support which doesn't really buy us anything and makes more work for > users. I guess I should explain this one a little more. There is an existing I2S driver in mach-tegra that has nothing to do with the new ALSA driver in sound/soc. It exports a custom interface to various user-space code which controls the associated codec etc. Currently, this driver is unconditionally compiled into the kernel, and this patch simply allows the user not to compile it in, so that it won't conflict with the new ALSA I2S driver. In the long term (or perhaps even short term), I wonder if this non-ALSA driver will simply go away. > No need for default n either - it's the default default. Thanks. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
