Re: [PATCH] video: tegra: host: Fix bounds- and error-checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 16, 2010 at 2:41 PM, Robert Morell <rmorell@xxxxxxxxxx> wrote:
*snip*
> @@ -106,7 +106,7 @@ static int nvhost_channelopen(struct inode *inode, struct file *filp)
>        gather_size = sizeof(struct nvhost_op_pair) * NVHOST_MAX_GATHERS;
>        priv->gather_mem = nvmap_alloc(ch->dev->nvmap, gather_size, 32,
>                                       NVMAP_HANDLE_CACHEABLE);
> -       if (IS_ERR(priv->gather_mem))
> +       if (IS_ERR_OR_NULL(priv->gather_mem))

>From my reading of nvmap_alloc, it will never return NULL.  Have you
seen otherwise?

-Erik
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux