> -----Original Message----- > From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel- > owner@xxxxxxxxxxxxxxx] On Behalf Of Rhyland Klein > Sent: Wednesday, October 20, 2010 10:52 AM > To: Mark Brown > Cc: cboutatmailru@xxxxxxxxx; Andrew Chew; olof@xxxxxxxxx; linux- > tegra@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: RE: [PATCH 1/1] power: bq24617: Adding initial charger support > > > From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx] > > Sent: Tuesday, October 19, 2010 8:03 PM > > To: Rhyland Klein > > Cc: cboutatmailru@xxxxxxxxx; Andrew Chew; olof@xxxxxxxxx; linux- > > tegra@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/1] power: bq24617: Adding initial charger support > > > > On Tue, Oct 19, 2010 at 07:17:11PM -0700, rklein@xxxxxxxxxx wrote: > > > From: Rhyland Klein <rklein@xxxxxxxxxx> > > > > > > Initial checkin adding basic support for the TI BQ24617 battery charger > > on the > > > Nvidia Tegra architecture. > > > > Why is this driver dependant on the CPU? I can't see anything in the > > code that makes it so. > > In hindsight this isn't the most accurate statement. The driver itself is > not dependent on the CPU, it is dependent on the platform design, and in > particular requires the PG line to be piped in through a GPIO. Would it > make more sense to make the driver dependent on GPIO instead? > Sorry for the confusion on this, I am removing the TEGRA dependency as it isn't necessary. > > > > > + if (old_status != -1 && > > > + old_status != new_status) { > > > + dev_dbg(&chip->pdev->dev, > > > + "%s: %i -> %i\n", __func__, old_status, > > > + new_status); > > > + kobject_uevent(&chip->power_supply.dev->kobj, KOBJ_CHANGE); > > > > power_supply_changed(). > > Alright. > > > > > > +static irqreturn_t bq24617_irq_switch(int irq, void *devid) > > > +{ > > > + struct bq24617_info *chip = devid; > > > + > > > + schedule_work(&chip->ac_work); > > > + > > > + return IRQ_HANDLED; > > > +} > > > > You're looking for a threaded IRQ handler here - use > > request_threaded_irq() with no primary handler. > > Alright I will look into this. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
