Re: [PATCH] spi: tegra: fix error setting on timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 13, 2010 at 06:16:38PM -0700, Erik Gilling wrote:
> avoids derefencing an uninitialized pointer
> 
> Change-Id: Icf528441ae481e9f6f5ddc0be32c7c217fa49701
> Signed-off-by: Erik Gilling <konkers@xxxxxxxxxxx>

Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>

> ---
>  drivers/spi/spi_tegra.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/spi/spi_tegra.c b/drivers/spi/spi_tegra.c
> index 0385fde..bb7df02 100644
> --- a/drivers/spi/spi_tegra.c
> +++ b/drivers/spi/spi_tegra.c
> @@ -338,15 +338,15 @@ static void tegra_spi_rx_dma_complete(struct tegra_dma_req *req)
>  
>  	spin_lock_irqsave(&tspi->lock, flags);
>  
> -	if (timeout >= 1000)
> -		m->status = -EIO;
> -
>  	val = spi_tegra_readl(tspi, SLINK_STATUS);
>  	val |= SLINK_RDY;
>  	spi_tegra_writel(tspi, val, SLINK_STATUS);
>  
> -
>  	m = list_first_entry(&tspi->queue, struct spi_message, queue);
> +
> +	if (timeout >= 1000)
> +		m->status = -EIO;
> +
>  	spi = m->state;
>  
>  	tspi->cur_pos += spi_tegra_drain_rx_fifo(tspi, tspi->cur);
> -- 
> 1.7.3.1.1.g1cf9a4
> 
> 
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux