Re: [PATCH 0/3] [ARM] tegra: PCI Express support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 20 September 2010, Mike Rapoport wrote:
> static struct resource pcie_res[] = {
>         [0] = {
>                 .name   = "PCIe IO",
>                 .start  = 0x1000,
>                 .end    = 0x1000 + IO_SIZE - 1,
>                 .flags  = IORESOURCE_IO,
>         },

The end should be 'IO_SIZE - 1' or IO_SPACE_LIMIT (should be the same anyway),
not '0x1000 + IO_SIZE - 1'. The reason for the 0x1000 is that the first 4096
ports are reserved for legacy ISA devices by setting PCIBIOS_MIN_IO.

The rest looks fine AFAICT.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux