Re: Issues when using AIO - WRITE_SAME not supported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 8 Oct 2018 11:18:58 -0400
Mike Boruta <mikeboruta1@xxxxxxxxx> wrote:

> 1. Is there a reason why bs_create_opcode_map() is not already used
> for AIO?

Few uses the AIO backing so nobody has tried to fix it about this.

> 2. Is my understanding of the situation somewhat correct?

Looks correct to me.

> 3. I just copy-pasted opcodes from bs_rdwr.c's sbc_opcodes[] and
> removed the WRITE_SAME* operations because I did not know what other
> opcodes the AIO block store supports. This is not more permissive than
> what is on master, but a proper patch would include just the opcodes
> that are supported...sadly I do not know how to find this out.

I guess that your patch does enough. Please resend it with your
signed-off. I'll push it.

> 4. I did not run unit tests on these changes.
> 
> This is my first submission to a mailing list, thank you for your
> patience and looking forward to having this issue fixed, either via
> this patch or something else entirely.
> 




[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux