Re: Resend [PATCH 2/2] convert scsi_cmnd.h macro to normal functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu,  2 Jun 2016 15:17:11 +0800
Feng Li <li.feng@xxxxxxxxxx> wrote:

> From: Feng Li <lifeng1519@xxxxxxxxx>
> 
> When I read this code, I found it's hard to understand about these macros.
> I hardly find where are the definitions of some functions.
> Therefore, I expand them to normal functions for convience.
> 
> Signed-off-by: Feng Li <lifeng1519@xxxxxxxxx>
> ---
>  usr/scsi_cmnd.h | 298 ++++++++++++++++++++++++++++++++------------------------
>  1 file changed, 170 insertions(+), 128 deletions(-)

Sorry, I'm not inclined to apply this.

I agree that it's hard to understand these macros however it has been
working. Also it's unlikely that we would need to change them
frequently. So I want to avoid change the working code just for
readability.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux