Is equivalent and nicer-looking. Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> --- usr/bs.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/usr/bs.c b/usr/bs.c index d6b8015..1ab86f7 100644 --- a/usr/bs.c +++ b/usr/bs.c @@ -122,11 +122,9 @@ retry: } pthread_mutex_lock(&finished_lock); -retest: - if (list_empty(&finished_list)) { + + while (list_empty(&finished_list)) pthread_cond_wait(&finished_cond, &finished_lock); - goto retest; - } while (!list_empty(&finished_list)) { cmd = list_first_entry(&finished_list, @@ -228,16 +226,13 @@ static void *bs_thread_worker_fn(void *arg) sigfillset(&set); sigprocmask(SIG_BLOCK, &set, NULL); - while (1) { pthread_mutex_lock(&info->pending_lock); pthread_cleanup_push(mutex_cleanup, &info->pending_lock); - retest: - if (list_empty(&info->pending_list)) { - pthread_cond_wait(&info->pending_cond, &info->pending_lock); - goto retest; - } + while (list_empty(&info->pending_list)) + pthread_cond_wait(&info->pending_cond, + &info->pending_lock); cmd = list_first_entry(&info->pending_list, struct scsi_cmd, bs_list); -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html