On Wed, 12 Mar 2014 10:55:24 -0400
Dan Lambright <dlambrig@xxxxxxxxxx> wrote:
> Gluster is a distributed file system (www.gluster.org). The
> backing store gives block access protocols such as iSCSI
> access to data within gluster.
>
> Gluster data resides on volumes which are physically located
> on servers. A "LUN" is represented by a file within
> a volume. To specify which file to use:
>
> --bstype=glfs
> --backing-store="volume@hostname:filename"
>
> Optionally, logs may be specified. See README.glfs
>
> All I/Os are synchronous. This is based off the rdrw and
> rbd backend storage drivers.
>
> Signed-off-by: Dan Lambright <dlambrig@xxxxxxxxxx>
> ---
> Makefile | 1 +
> doc/README.glfs | 50 +++++
> usr/Makefile | 7 +
> usr/bs_glfs.c | 561 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Thanks! Can you fix the following some style errors?
fujita@rose:~/git/tgt$ ./scripts/checkpatch.pl
~/0001-Add-support-for-gluster-backing-store.patch
WARNING: quoted string split across lines
#370: FILE: usr/bs_glfs.c:239:
+ eprintf("Failed to punch hole for "
+ "WRITE_SAME
command\n");
WARNING: quoted string split across lines
#481: FILE: usr/bs_glfs.c:350:
+ eprintf("Failed to punch hole for"
+ "
UNMAP at offset:%" PRIu64
WARNING: line over 80 characters
#557: FILE: usr/bs_glfs.c:426:
+ ret = glfs_set_volfile_server(fs, "tcp", servername,
GLUSTER_PORT);
ERROR: code indent should use tabs where possible
#615: FILE: usr/bs_glfs.c:484:
+ /* Jump past the semicolon, if we stopped at one */$
ERROR: code indent should use tabs where possible
#616: FILE: usr/bs_glfs.c:485:
+ if (**p == ';')$
WARNING: please, no spaces at the start of a line
#616: FILE: usr/bs_glfs.c:485:
+ if (**p == ';')$
ERROR: code indent should use tabs where possible
#617: FILE: usr/bs_glfs.c:486:
+ *p = end + 1;$
WARNING: please, no spaces at the start of a line
#617: FILE: usr/bs_glfs.c:486:
+ *p = end + 1;$
total: 3 errors, 5 warnings, 637 lines checked
NOTE: whitespace errors detected, you may wish to use
scripts/cleanpatch or
scripts/cleanfile
/home/fujita/0001-Add-support-for-gluster-backing-store.patch has
style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
