On Mon, 10 Feb 2014 14:12:46 -0800
Dan Mick <dan.mick@xxxxxxxxxxx> wrote:
> except for the one if() with no space after the 'if':
>
> Reviewed-by: Dan Mick <dan.mick@xxxxxxxxxxx>
Thanks, applied. checkpatch.pl complains about the that if(). I fixed
the following warnings:
fujita@rose:~/git/tgt$ ./scripts/checkpatch.pl ~/2
ERROR: do not use C99 // comments
#124: FILE: usr/bs_rbd.c:526:
+ // look for conf= or id= or cluster=
WARNING: line over 80 characters
#146: FILE: usr/bs_rbd.c:553:
+ /* If clustername is set, then we use rados_create2, else
rados_create */
ERROR: space required before the open parenthesis '('
#149: FILE: usr/bs_rbd.c:556:
+ if(clientid)
WARNING: line over 80 characters
#150: FILE: usr/bs_rbd.c:557:
+ snprintf(clientid_full, sizeof clientid_full,
"client.%s", clientid);
WARNING: line over 80 characters
#152: FILE: usr/bs_rbd.c:559:
+ snprintf(clientid_full, sizeof clientid_full,
"client.admin");
WARNING: line over 80 characters
#153: FILE: usr/bs_rbd.c:560:
+ rados_ret = rados_create2(&rbd->cluster, clustername,
clientid_full, 0);
total: 2 errors, 4 warnings, 59 lines checked
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
