Re: [PATCH] util.h: correct range check of str_to_int_gt() and str_to_int_lt()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 10 Dec 2013 13:49:47 +0900
Ryusuke Konishi <konishi.ryusuke@xxxxxxxxxxxxx> wrote:

> The range checks of str_to_int_gt() and str_to_int_lt() are not
> implemented literally.  The current definitions fail to reject a
> marginal value.
> 
> Due to this difference, tgtd accepts option "-t 0" without an error,
> which overrides nr_iothreads to 0 and causes clients to hang.
> 
> This corrects str_to_int_gt()/str_to_int_lt() and prevents the issue.
> 
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxxxxxx>
> ---
>  usr/util.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Nice catch, thanks!
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux