On Tue, 13 Aug 2013 17:44:15 +0300 Or Gerlitz <ogerlitz@xxxxxxxxxxxx> wrote: > On 13/08/2013 02:55, FUJITA Tomonori wrote: >> On Thu, 8 Aug 2013 16:03:34 +0300 >> Shlomo Pongratz <shlomop@xxxxxxxxxxxx> wrote: >> >>> This patch series does two things. >>> >>> The first patch is a restructuring patch that makes it easy to >>> configure tgtd local parameters via tgtadm. >>> Local parmeters in this context are parameters that are not sent to >>> the initiator. >>> Currently there is one such parameter i.e. MaxXmitDataSegmentLength. >>> >>> The second patch makes use of the first one in order to add a new >>> parameter named MaxQueueCmd. >>> The value of this parameter varies between 1 and 512, and is default >>> value is set to 128 in order to keep backward compatibility. >>> The need for the 2nd patch raised when running tgt against optimized >>> iser initiators, >>> where the hard-coded value of 128 in-flight command become a >>> bottleneck for the maximal number of IOPS. >>> Once addressed we were able to get decent improvement. >>> >>> >>> Shlomo Pongratz (2): >>> Enable more iscsi local params >>> Add MaxQueueCmd iscsi local parameter >>> >>> usr/iscsi/iscsi_if.h | 5 ++++- >>> usr/iscsi/iscsid.c | 26 +++++++++++++++----------- >>> usr/iscsi/iscsid.h | 5 +++++ >>> usr/iscsi/iser.c | 15 ++++++++------- >>> usr/iscsi/iser_text.c | 4 ++-- >>> usr/iscsi/param.c | 8 ++++++-- >>> usr/iscsi/session.c | 2 ++ >>> usr/iscsi/target.c | 4 +++- >>> 8 files changed, 45 insertions(+), 24 deletions(-) >> Looks reasonable. Applied, thanks. >> > Hi Tomo, > > I don't see the 2nd patch on your git, only the 1st one, was that > somehow forgotten? Oops, I fixed some checkscript warnings and applied. Thanks, -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html