Re: [PATCH] iser: add CQ vector param

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 24 Feb 2013 14:46:18 +0200
Roi Dayan <roid@xxxxxxxxxxxx> wrote:

> Different vector means different EQ which means different IRQ
> which will let us do affinity to different CPU set.
> Default vector is modulus of the control port and max vector allowed.
> 
> Signed-off-by: Roi Dayan <roid@xxxxxxxxxxxx>
> ---
>  usr/iscsi/iser.c |   24 +++++++++++++++++++++++-
>  1 files changed, 23 insertions(+), 1 deletions(-)

Thanks, can you fix the following warnings? If it's difficult, I apply
this though.

fujita@rouen:~/git/tgt$ ./scripts/checkpatch.pl ~/Mail/inbox/2
WARNING: externs should be avoided in .c files
#87: FILE: usr/iscsi/iser.c:3237:
+    extern short control_port;

WARNING: suspect code indent for conditional statements (8, 12)
#96: FILE: usr/iscsi/iser.c:3270:
+    if (cq_vector < 0)
+        cq_vector = control_port % dev->ibv_ctxt->num_comp_vectors;

WARNING: suspect code indent for conditional statements (24, 28)
#127: FILE: usr/iscsi/iser.c:3537:
+		if (cq_vector < 0)
+		   	          eprintf("unsupported value for
param: %s\n",

total: 0 errors, 3 warnings, 55 lines checked


--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux