On Sat, Aug 18, 2012 at 7:10 PM, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote: > On Sat, 18 Aug 2012 18:56:09 +1000 > ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote: > >> The bug is that IF the initiator does state it can handle larger >> DATA-IN PDUs than 8kb, like open-iscsi does, and all other iniators >> also does. > > btw, I've seen initiators that don't send > MaxRecvDataSegmentLength long ago. I can't recall what. > > >> The b\ug in tgtd in processing the login is that tgtd ONLY parses this >> "lets use bigger than 8kb pdu" IFF the session is a discovery session, >> but not for NORMAL sessions. > > Can you recall why we handle discovery and normal sessions differently? > The parameter MaxRecvDataSegmentLength is meaningless for a discovery session. It only applies to NORMAL sessions when the receipient of this will learn the max size of DATA-IN/-OUT PDUs it can send to the other side. Currently TGTD has a trivial bug where it ONLY parses this parameter IFF session is DISCOVERY. This is a trivial error since it is obvious the conditional should only apply to session type NORMAL. regards ronnie sahlberg -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
