On Thu, Aug 9, 2012 at 7:35 PM, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote: > On Wed, 8 Aug 2012 10:03:20 +0300 > nezhinsky@xxxxxxxxx wrote: >> This is a series of patches for a few "main" sources files. >> It fixes the style errors and warnings detected by curent version of checkpatch.pl. > Sorry, as I said before, I don't like to apply 'pure style fix' patches. Tomo, It was my understanding that we had agreed upon such 'pure style fix' : >> Let's tolerate those 80 chars transgressions as they are just for now >> and fix them all in one blow. >> I'm more than ready to produce a "style improvement" patch-set if we >> decide that it is due. > > ok, I've applied and pushed. Thanks. >> Another ignored warning is about returning errno codes from the program. >> The checker stipulates returning negative values which is the kernel convention. >> We seem to need to return positive values, don't we? > Any reason of returning a negative value is bad for us? Not especially, but our code has been returning positive errnos as a matter of fact, so i did not want to change this out of style reasons only. There is a substantial reason for returning negatives from kernel so the style checker follows suite, but we can do it either way. Alexander -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
