On Tue, 17 Jul 2012 22:39:15 +0000 Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> wrote: > From: FUJITA Tomonori [fujita.tomonori@xxxxxxxxxxxxx] > Sent: Wednesday, July 18, 2012 1:05 AM > > On Wed, 18 Jul 2012 00:55:43 +0300 > nezhinsky@xxxxxxxxx wrote: > > >> From: Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> > >> > >> Add statistics on SCSI cmd execution ... > > > I got many checkpatch errors on them. Please fix them. > > Fixed 2 patches where some glitches unrelated to "line over 80 chars" > were found. A couple of other warnings, if fixed, would disrupt the de-facto style > like no space before bracket in "int (*f)(void)" You can ignore some warnings if fixing these warnings would lead to ugly code. However, I'm not sure why you can't fix something like the following: WARNING: line over 80 characters #250: FILE: usr/iscsi/iser.c:2931: + iscsi_update_conn_stats_rx(&conn->h, rdmad->sge.length, ISCSI_OP_SCSI_DATA_OUT); -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
