Hi Tomo, Upon reviewing the code I could see the problem with stopping an lld. I'll resend the patches with fixes to lld stop safely. Thanks, Roi -----Original Message----- From: stgt-owner@xxxxxxxxxxxxxxx [mailto:stgt-owner@xxxxxxxxxxxxxxx] On Behalf Of Roi Dayan Sent: Sunday, June 17, 2012 1:58 PM To: FUJITA Tomonori Cc: stgt@xxxxxxxxxxxxxxx Subject: RE: [PATCH 0/3] lld restart The patch only adds the new mode and operations for it It doesn't cover what happens exactly in init and exit of the LLDs. I looked in the exit function on both iSCSI and iSER LLDs and they don't do much On stop the iSCSI LLD only calls tgt_event_del on listen fds so it won't accept new connections, active connections will continue as normal. The iSER LLD removes nop handling work so everything will continue to work as expected just without nops. So actually needs another patch to change how exit() is implemented on each LLD so stop will do something meaningful. Currently, the patch is useful to start LLDs rather than stopping. Thanks, Roi -----Original Message----- From: FUJITA Tomonori [mailto:fujita.tomonori@xxxxxxxxxxxxx] Sent: Sunday, June 17, 2012 2:09 AM To: Roi Dayan Cc: fujita.tomonori@xxxxxxxxxxxxx; stgt@xxxxxxxxxxxxxxx Subject: Re: [PATCH 0/3] lld restart On Mon, 11 Jun 2012 15:14:32 +0300 Roi Dayan <roid@xxxxxxxxxxxx> wrote: > Hi Tomo, > > Here's a set of 3 patches to add option to stop and start lld without > restarting the tgtd process and corresponding short help for tgtadm (--help) and the man page. > Can be used for example if tgtd was started before the rdma modules > were loaded so we can later load the modules and call iser init() with: > tgtadm --mode lld --lld iser --op start > > Thanks, > Roi > > > Roi Dayan (3): > tgt-admin: add option to restart llds > Add documentation for starting lld while tgtd is running > tgtadm: add help for starting lld while tgtd is running > > doc/tgtadm.8.xml | 10 ++++++++++ > usr/mgmt.c | 45 ++++++++++++++++++++++++++++++++++++++++++++- > usr/target.c | 13 +++++++++++++ > usr/tgtadm.c | 27 +++++++++++++++++++++++++++ > usr/tgtadm.h | 3 +++ > usr/tgtd.c | 35 ++++++++++++++++++++++------------- > usr/tgtd.h | 3 +++ > 7 files changed, 122 insertions(+), 14 deletions(-) What if we try to stop the lld of targets with outstanding commands? -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
