On Fri, 18 May 2012 13:24:22 +0300 nezhinsky@xxxxxxxxx wrote: > From: Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> > > Improving tgtadm_err error processing and fixing some functions returning > tgtadm_err values but declared as returning int, or mixing error.h style values > with tgtadm_err. > > Alexander Nezhinsky (7): > move set_mtask_result() call to mtask_received() > change return value of isns_show() and isns_update() to tgtadm_err > change return value of some show functions in iscsi/target.c to > tgtadm_err > change return value of dtd_check_removable() to tgtadm_err, update > use cases > change return value of system_set_state() to tgtadm_err, update use > cases > change return value of slot_insert() to tgtadm_err and recover from > errors properly in add_slt() > change return value of iqn_acl_add() and iqn_acl_del() to tgtadm_err > > usr/iscsi/iscsid.h | 4 ++-- > usr/iscsi/isns.c | 16 ++++++------- > usr/iscsi/target.c | 66 ++++++++++++++++++++++++++++------------------------ > usr/mgmt.c | 23 +++++++----------- > usr/smc.c | 28 +++++++++++++++++----- > usr/target.c | 25 ++++++++++---------- > usr/tgtd.h | 8 +++---- > 7 files changed, 92 insertions(+), 78 deletions(-) Applied, thanks a lot! Looks straight fixes except for 6/7. It changes the behavior a bit but the change looks reasonable. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html