On Wed, 25 Apr 2012 17:52:13 +0300 nezhinsky@xxxxxxxxx wrote: > From: Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> > > Different compiler warnings are produced by various versions of gcc, shipped under different > distros. Here is a list of patches prompted by some of the warnings. > > [1/8] Fix string to integer conversion and error handling in get_bsg_major() > [2/8] If param check fails during iscsi login text processing, answer that key with Reject. There are other possible choices. Please read the patch comment. Objections? > [3/8] Store iscsi initiator alias in connection, copy it to iscsi session, show it in session info > [4/8] In sbc.c implementation of synchronize cache, set resid to 0 unconditionally > [5/8] Improve str_to_int() boundary checking scheme; change its format accordingly > [6/8] Fix "set but not used" warning in iser.c, related to unused irdsl value > [7/8] If adding Unit Attention sense fails upon target destroy, just return TGTADM_SUCCESS > [8/8] Make sure that read from eventfd uses 64-bit integer in bs_aio, and cast it to unsigned > > usr/bs_aio.c | 12 ++++++---- > usr/bs_sg.c | 18 ++++++++++----- > usr/iscsi/conn.c | 2 ++ > usr/iscsi/iscsid.c | 8 +++++++ > usr/iscsi/iscsid.h | 2 ++ > usr/iscsi/iser.c | 6 +++-- > usr/iscsi/iser_text.c | 9 ++++++++ > usr/iscsi/session.c | 16 ++++++++++++-- > usr/sbc.c | 6 ++--- > usr/target.c | 3 +++ > usr/tgtadm.c | 12 +++++----- > usr/tgtd.c | 6 ++--- > usr/util.h | 58 ++++++++++++++++++++++++++++++++++++++++++------- > 13 files changed, 125 insertions(+), 33 deletions(-) Looks good. Applied, thanks a lot! Please use the proper subject and the patch description in each patch next time. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html