On Fri, Jan 20, 2012 at 4:08 AM, FUJITA Tomonori < fujita.tomonori@xxxxxxxxxxxxx> wrote: > On Thu, 19 Jan 2012 12:01:11 +0000 > "Alexander Nezhinsky" <nezhinsky@xxxxxxxxx> wrote: > > > I agree that encapsulation of concat_buf in mtask is cleaner and > simpler, but I think that exposing FILE* when writing to socket or using > mechanisms like splice are an overkill, even more than exposing size in > mgmt.c > > Yeah, we need helper functions to handle FILE* internally. So mgmt.c > doesn't need to handle FILE* directly. That's what you suggest below, > right? > > Can you send a new patch for only mgmt.c with the modified concat_buf > patch? > The patches influenced also util.h and tgtadm.c, so it's already 3 patches, plus after all the fixes and rebase it was difficult to keep the two-step incremental patch scheme, so i'm going to produde a new RESEND series that changes all files in one step, file by file. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
