On Sun, 07 Aug 2011 17:23:05 +0200 Môshe van der Sterre <me@xxxxxxxx> wrote: > I have looked a bit at the code implementing iSNS, and it seems to me > SLP support could use the same general design as the iSNS code. > > Am I correct in the following assumptions? > * A function slp_target_register, called at the end of > * iscsi_target_create could be created that collects ACL information and > * passes this to SLPReg (from OpenSLP). > * Simmilarly, a function slp_target_unregister, called at the end of > * iscsi_target_destroy could be created to deregister. > * iscsi_target_update should call an 'update' function, for setting SLP > * on/off. Yeah, sounds reasonable to me. > * Code could possibly be shared with the iSNS feature, but this requires > * changing a lot of the iSNS code. If the changes make the iSNS code too complicated, I prefer to have separate SLP code. Otherwise, sharing sounds fine. > If there is an interest in this, I can spend some time trying to > implement this. (If there isn't I can just write a wrapper script that > calls the slptool to register/deregister, I don't really need the ACL > features) I'm very happy to merge slp support if you (or someone) send patches. Thanks! -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html