Please find attached an updated patch regards ronnie sahlberg On Tue, Apr 5, 2011 at 12:30 AM, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote: > On Mon, 4 Apr 2011 19:07:25 +1000 > ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote: > >> From 90ef6c74e08d02400433ad523b6e14820b8b66c9 Mon Sep 17 00:00:00 2001 >> From: Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx> >> Date: Mon, 4 Apr 2011 19:02:59 +1000 >> Subject: [PATCH] READ6/WRITE6 A transfer length value of 0 means the SCSI task will read/write >> 256 blocks. >> >> >> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx> >> --- >> usr/scsi.c | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/usr/scsi.c b/usr/scsi.c >> index cef231b..b46d4c1 100644 >> --- a/usr/scsi.c >> +++ b/usr/scsi.c >> @@ -152,6 +152,9 @@ uint32_t scsi_rw_count(uint8_t *scb) >> case READ_6: >> case WRITE_6: >> cnt = scb[4]; >> + if (cnt == 0) { > > if (!cnt) { > > It's Linux kernel style. > > Can you send the updated patch? > > Thanks, >
Attachment:
0001-READ6-WRITE6-A-TransferLength-of-0-means-we-want-to-.patch.gz
Description: GNU Zip compressed data
From a1d75b96972b49702b9e413c6177447e840e10e4 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx> Date: Tue, 5 Apr 2011 06:16:32 +1000 Subject: [PATCH] READ6/WRITE6: A TransferLength of 0 means we want to transfer 256 blocks Signed-off-by: Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx> --- usr/scsi.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/usr/scsi.c b/usr/scsi.c index cef231b..9ab1bde 100644 --- a/usr/scsi.c +++ b/usr/scsi.c @@ -152,6 +152,9 @@ uint32_t scsi_rw_count(uint8_t *scb) case READ_6: case WRITE_6: cnt = scb[4]; + if (!cnt) { + cnt = 256; + } break; case READ_10: case WRITE_10: -- 1.7.3.1