On Mon, 17 Jan 2011 16:55:18 +0200 Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> wrote: > > If you don't care about old kernels much, I like to have the timerfd > > and old jiffies code. If you care, I add the timerfd code and yours. > > I do care for old kernels, and don't like combining timerfd and jiffies. > So please add timerfd / timer signal combination. Whether to retain > gettimeofday or not, is up to you, i'm ok with both. I don't want to use gettimeofday for timerfd code. You really need several msecs accuracy? Even if add_work() argument is second accuracy. > > sched_remains = tgt_exec_scheduled(); > > - timeout = sched_remains ? 0 : TGTD_TICK_PERIOD * 1000; > > + timeout = sched_remains ? 0 : -1; > > > > nevent = epoll_wait(ep_fd, events, ARRAY_SIZE(events), timeout); > > This is, of course, right. Please send an updated patch. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html