Re: [PATCH 1/1] tgtd: allow 'immutable' files and have them become read-only LUNs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Agree that it is suboptimal, but changing the signature would have
been more intrusive.

Do you want to to re-do the patch differently to pass flags to the
function instead.

Or optionally, the same functionality could be provided instead
through a new    bs_rdonly.c  backend.
Do you want to to implement a replacement patch?


regards
ronnie sahlberg


On Tue, Oct 12, 2010 at 12:20 PM, FUJITA Tomonori
<fujita.tomonori@xxxxxxxxxxxxx> wrote:
> On Sun, 10 Oct 2010 16:28:29 +1100
> ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote:
>
>> Please find attached a small patch to the three bs_*.c files used for
>> SBC and MMC devices.
>> The patch changes the *_open() function in such way that if the normal
>> open for O_RDWR fails with EACCES,
>> we try to open the file with O_RDONLY instead, and set the LUN to read-only.
>
> Applied, thanks.
>
> Doesn't look pretty. It's better if we can use the proper flag for the
> first open(). But it needs more changes. This patch is trivial so I
> merged it.
>
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux