FUJITA Tomonori wrote: > With the duplication, I can just tell you that iSCSI/tcp has a bug so > iser might have the similar one. When I understand the iser code, I > could work on the unification. That's ok with me. Still, one thing that i would do before starting with the new iser patches is: >>>> ... the "rectification" of iscsi text functions, by >>>> changing them to accept plain char * buffers, making them independent from >>>> iscsi structures specifics. Such semantic changes do not alter the logic >>>> of the existing code... This would make the duplicated code almost twice less and clearly will not bother you when you change iscsi/tcp. Also, no further expert opinion is needed. So if you "ok" it, i can send the patches for text functions only, this time the "real" ones. > What parts of iscsid.c iser needs is clearer a bit. If you > can do something for that direction on your patches, please let me > know. Sure, I'll have a look at it. > However, as I said before, before I merge your iser work, I really > like to get other iser experts' opinion on the new state machine code. This is reasonable. And again, i can explain the rationale and design if needed. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
